plat: rcar: Rework board id handling #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yaaaaao
commented
May 3, 2017
Yaaaaao
commented
- prefer board ID specified during compiling
- board ID read from PMIC EEPROM if it is valid
- fallback to Salvator-X Rev1.0
added 2 commits
May 3, 2017 10:57
Detection rule: - prefer board ID specified during compiling - board ID read from PMIC EEPROM if it is valid - fallback to Salvator-X Rev1.0
Add makefile options BOARD_ID=0xXX to specify the board for which the IPL is built.
Yaaaaao
commented
May 19, 2017
| g_board_id = BOARD_DEFAULT; | ||
| #endif | ||
| } | ||
| return board_name[board_id]; |
There was a problem hiding this comment.
please note the bug in get_board_name. the board name id is (board_id >> BOARD_NAME_ID_SHIFT).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.